Repository navigation
Conversation
Game cards and the game page showed tags as bare chips in a <div>,
spaced only by margins, so screen readers, copy-paste and text tools got
one run-on word ("soloplatformroguelikeaction").
A TagList component renders them as a list labelled "Tags", one item per
tag, spaced with gap; on the game page each tag still links to the
filtered games list (its name is now URL-encoded). They look the same.
Fixes #201.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
Contributor
Author
|
Superseded by #249, which merged this change into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201.
Game cards and the game page rendered tags as bare chips inside a
<div>, spaced only by CSS margins. Screen readers, copy-paste and text tools got one run-on word, e.g. "soloplatformroguelikeaction".Change
TagList(app/components/TagList.jsx) renders tags as a list labelled "Tags", oneliper chip, spaced withgap.linked, each tag still links to/games?tags=<name>, now URL-encoded.Not changed: the tag filter on
/games. Those chips are clickable but aren't buttons, so they can't be reached with the keyboard. That's a separate accessibility fix, worth its own issue.Tests
A new e2e test opens
/gamesand checks:On
main: it fails. Locally: the full e2e suite (38) and the unit and story tests (51) pass.🤖 Generated with Claude Code